Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signac project --access should be deprecated #303

Closed
bdice opened this issue Mar 11, 2020 · 3 comments · Fixed by #308
Closed

signac project --access should be deprecated #303

bdice opened this issue Mar 11, 2020 · 3 comments · Fixed by #308
Assignees
@kidrahahjo
Labels
Click Related to refactoring CLI with Click.
Milestone
v1.5.0

Comments

@bdice
Copy link
Member

bdice commented Mar 11, 2020

This signac project --access generates a file signac_access.py that uses deprecated functionality. This feature of the CLI should be deprecated.

Originally discussed with @csadorf in #300.
@bdice bdice added the Click Related to refactoring CLI with Click. label Mar 11, 2020
@bdice bdice mentioned this issue Mar 11, 2020
Merged
12 tasks
@bdice bdice added this to the v1.5.0 milestone Mar 16, 2020
@kidrahahjo
Copy link
Collaborator

@bdice May I resolve this?

@bdice
Copy link
Member Author

bdice commented Mar 19, 2020

@kidrahahjo Sure! Please deprecate def create_access_module in project.py and adapt the tests / deprecation warnings accordingly.

@kidrahahjo
Copy link
Collaborator

@bdice Sure

@kidrahahjo kidrahahjo mentioned this issue Mar 19, 2020
Merged
12 tasks
@bdice bdice closed this as completed in #308 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kidrahahjo kidrahahjo

Labels
Click Related to refactoring CLI with Click.
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Deprecation of create_access_module method kidrahahjo/signac
2 participants
@bdice @kidrahahjo