Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block merging with incomplete PR check list #707

Open
cbkerr opened this issue Mar 4, 2022 · 4 comments
Open

Block merging with incomplete PR check list #707

cbkerr opened this issue Mar 4, 2022 · 4 comments
Labels

Comments

@cbkerr
Copy link
Member

cbkerr commented Mar 4, 2022

Feature description

After streamlining the PR template to include a checklist that must be completed (#686), I think having an automatic check would be a helpful reminder to reviewers. Would it be too heavy handed?

However, there is no way yet to have github automatically block merging with an incomplete "task list". (https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists)

Proposed solution

With some quick searching this seems like an option: https://github.com/stilliard/github-task-list-completed.
Note the external privacy policy: https://blog.stapps.io/privacy/#appssuchastasklistcompleted

@vyasr
Copy link
Contributor

vyasr commented Mar 14, 2022

A different but somewhat related request: it would be nice if labeling a PR as "blocked" would actually prevent merging until that label is removed to avoid accidental merges.

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2022
@stale stale bot closed this as completed Jul 31, 2022
@cbkerr cbkerr reopened this Aug 15, 2022
@stale stale bot removed the stale label Aug 15, 2022
@vyasr
Copy link
Contributor

vyasr commented Nov 2, 2022

@cbkerr are you still interested in adding this to signac (and maybe porting it to other repos as well if it works well here)?

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants