-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block merging with incomplete PR check list #707
Comments
A different but somewhat related request: it would be nice if labeling a PR as "blocked" would actually prevent merging until that label is removed to avoid accidental merges. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@cbkerr are you still interested in adding this to signac (and maybe porting it to other repos as well if it works well here)? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Feature description
After streamlining the PR template to include a checklist that must be completed (#686), I think having an automatic check would be a helpful reminder to reviewers. Would it be too heavy handed?
However, there is no way yet to have github automatically block merging with an incomplete "task list". (https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists)
Proposed solution
With some quick searching this seems like an option: https://github.com/stilliard/github-task-list-completed.
Note the external privacy policy: https://blog.stapps.io/privacy/#appssuchastasklistcompleted
The text was updated successfully, but these errors were encountered: