fix ticket list ignoring validation role #17200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
commented
May 29, 2024
btry
commented
May 29, 2024
btry
changed the title
btry
force-pushed
the
ticket_list_ignores_validation_role
branch
2 times, most recently
from
cabe62d
to
1254b32
Compare
btry
commented
Jun 10, 2024
| $restrict = self::getListForItemRestrict($item); | ||
| $criteria['WHERE'] = $restrict + getEntitiesRestrictCriteria(self::getTable()); | ||
| $criteria['WHERE']['glpi_tickets.is_deleted'] = 0; | ||
| $criteria['LIMIT'] = (int)$_SESSION['glpilist_limit']; | ||
|
|
||
| switch (get_class($item)) { |
There was a problem hiding this comment.
This switch statement needs to be splitted to make the SQL query unit testable
SQL related content moved in a new method
Search options criterias moved in a new method
Specific display and order stay here
btry
force-pushed
the
ticket_list_ignores_validation_role
branch
from
1254b32
to
de602e6
Compare
btry
force-pushed
the
ticket_list_ignores_validation_role
branch
from
de602e6
to
f1f4ea2
Compare
btry
force-pushed
the
ticket_list_ignores_validation_role
branch
from
f1f4ea2
to
dc10756
Compare
|
I focused on tests related to the fix; but it is now possible to add much more cases |
AdrienClairembault
approved these changes
Jun 24, 2024
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
cedric-anne
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GLPI shows a list of tickets it filters tickets by actors but forgets to filter also by validator
Joined with pluginsGLPI/formcreator#3511 for a possible ticket resolution.