afr: fix race between __afr_eager_lock_handle and afr_wakeup_same_fd_delayed_op (#4425) #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delayed_op (gluster#4425) Race between __afr_eager_lock_handle and afr_wakeup_same_fd_delayed_op will lead to stale inodelks, which may cause subsequent IO blocked. To avoid this race, set lock->release = _gf_true also in afr_wakeup_same_fd_delayed_op so that a new transaction can be correctly handled as expected in __afr_eager_lock_handle. Fixes: gluster#4425 Signed-off-by: chenjinhao <[email protected]>
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
amarts
approved these changes
Oct 26, 2024
|
/run regression |
|
1 test(s) failed 0 test(s) generated core 2 test(s) needed retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race between
__afr_eager_lock_handleandafr_wakeup_same_fd_delayed_opwill lead to stale inodelks, which may cause subsequent IO blocked. To avoid this race, setlock->release = _gf_truealso inafr_wakeup_same_fd_delayed_opso that a new transaction can be correctly handled as expected in__afr_eager_lock_handle.Fixes: #4425