Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side-Efect - WiFi.reconnect #19

Closed
vborcea opened this issue Mar 31, 2021 · 2 comments
Closed

Side-Efect - WiFi.reconnect #19

vborcea opened this issue Mar 31, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@vborcea
Copy link

vborcea commented Mar 31, 2021

Very nice work with the library.
I have one problem with it: the WiFi.reconnect. Do you think that it's OK to make this part optional?
Like, when the NTP.begin is called to receive a parameter that will say if the library should call the reconnect or not?
Please note that some projects are already handling these Wifi problems and the WifiReconnect improvement overlaps with them.
I can make a PR with this if you think that it's OK with you.
@gmag11
Copy link
Owner

gmag11 commented Jul 25, 2021

Hi, this is a nice idea. I'll implement it with a optional parameter bool manage_wifi with true as default, so that it can be disabled if you like. I'll put a note here when it is in dev branch. Thanks!

@gmag11 gmag11 added the enhancement New feature or request label Jul 25, 2021
@gmag11
Copy link
Owner

gmag11 commented Jul 25, 2021

It is there. Please test it and give me some feedback here :)

@gmag11 gmag11 closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmag11 @vborcea