Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auctions to work with Base contracts #20

Open
bagelface opened this issue Apr 12, 2024 · 4 comments
Open

Update auctions to work with Base contracts #20

bagelface opened this issue Apr 12, 2024 · 4 comments
Assignees
@asmattic
Labels
current scope Part of an active project scope

Comments

@bagelface
Copy link
Contributor

bagelface commented Apr 12, 2024 •
edited
Loading

Description 🗒️

Update the webapp auctions page to work with new the nouns.build contracts deployed on Base.

Details 🏗️

  • Update core auction functionality: Migrate all features from the previous auction component to work with the Base contracts. This includes bidding and dynamic data sources such as, but not limited to: auction end time, current bid, minimum next bid.
  • Update artwork viewer: Update artwork viewer to display the correct Gnars artwork from the Base contracts. These images should be pulled dynamically from the contract. It is no longer "onchain" artwork, the images are now hosted by Zora's IPFS endpoint.
  • Buttons require Base connection: Buttons that send a transaction are updated to not be "active" unless the user is connected to Base network. Otherwise these changes could easily result in a loss of user funds.
  • Remove "Pick the next Gnar" link: Base settles too quickly for picking the next Gnar to be realistic. This link should be removed and the UI should be updated to accommodate it's absence.
  • Remove "gnarving" content: On Base there is no longer a "gnarving", so we should remove any content on the page related to that, including the "X auctions until Gnarving" button.

Acceptance Criteria ☑️

  1. All of the changes described in the "Details" section above are implemented and manually tested.
  2. Code is clear, clean, and properly documented.
  3. UI changes are sensible and non-regressive.
@bagelface bagelface added enhancement New feature or request bounty Rewarded upon completion labels Apr 12, 2024
@ManyRios
Copy link

Can anyone claim the bounties? If so, I can help here.

@bagelface
Copy link
Contributor Author

Can anyone claim the bounties? If so, I can help here.

We give priority on bountied issues to people who are members of Gnars DAO. If you'd like to join us read through this https://github.com/gnars-dao and join us in the Discord, we'd be happy to have you: https://discord.com/invite/XBeZuMxmst

@ManyRios
Copy link

Can anyone claim the bounties? If so, I can help here.

We give priority on bountied issues to people who are members of Gnars DAO. If you'd like to join us read through this https://github.com/gnars-dao and join us in the Discord, we'd be happy to have you: https://discord.com/invite/XBeZuMxmst

Sure, ty

@reubenstein reubenstein mentioned this issue Apr 27, 2024
Open
@asmattic
Copy link
Collaborator

asmattic commented May 1, 2024

I'll start on this one and work with Rubinstein on any parallel overlap.

@bagelface bagelface added current scope Part of an active project scope and removed bounty Rewarded upon completion enhancement New feature or request labels Aug 2, 2024
@bagelface bagelface changed the title Frontend - Update webapp auctions to work with Base contracts Update auctions to work with Base contracts Aug 2, 2024
@bagelface bagelface mentioned this issue Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmattic asmattic

Labels
current scope Part of an active project scope
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asmattic @ManyRios @bagelface