Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proposal viewer to show Base proposals and details #22

Open
bagelface opened this issue Apr 13, 2024 · 5 comments
Open

Update proposal viewer to show Base proposals and details #22

bagelface opened this issue Apr 13, 2024 · 5 comments
Assignees
@0xMillz
Labels
current scope Part of an active project scope

Comments

@bagelface
Copy link
Contributor

bagelface commented Apr 13, 2024 •
edited
Loading

Description 🗒️

Update webapp proposal viewer to show Base proposals and details.

Details 🏗️

  • Update list of proposals: Update the proposal list view to show all the proposals made on the Base contracts.
  • Update proposal details view: Update the proposal detail viewer to show the details of any proposal made on the Base contracts. Replaced by new issue Update proposal viewer to show Base proposal details #46
  • Preserve mainnet proposal viewer code: Do not remove code, such as subgraphs, used for viewing mainnet proposals. We have plans to include an viewer for mainnet proposals alongside Base proposals to preserver the history of the DAO.

Acceptance Criteria ☑️

  1. All of the changes described in the "Details" section above are implemented and tested.
  2. Code is clear, clean, and properly documented.
  3. UI changes are sensible and non-regressive.
@bagelface bagelface added enhancement New feature or request bounty Rewarded upon completion labels Apr 13, 2024
@sktbrd
Copy link
Member

sktbrd commented Apr 17, 2024

Lets add markdown handlers for youtube, zora and other popular iframes that time

@bagelface
Copy link
Contributor Author

bagelface commented Apr 17, 2024 •
edited
Loading

Lets add markdown handlers for youtube, zora and other popular iframes that time

Definitely a nice thing to add, though I would advocate for creating a separate bounty ticket for that. I think it would bloat this one up too much.

@bagelface
Copy link
Contributor Author

Issue mentioned in "nouns infra" Discord that may affect this issue:
Screenshot 2024-05-08 at 7 30 33 PM
https://discord.com/channels/1133102918829101136/1133102919416287254/1237696543994282006

@reubenstein
Copy link

reubenstein commented May 24, 2024 •
edited
Loading

I've already done a lot of the BASE groundwork for this ticket while working on #23, so I'd be happy to start this one after I finish

@bagelface bagelface added current scope Part of an active project scope and removed bounty Rewarded upon completion enhancement New feature or request labels Aug 2, 2024
@bagelface bagelface changed the title Frontend - Update webapp proposal viewer to show Base proposals and details Update proposal viewer to show Base proposals and details Aug 2, 2024
@0xMillz 0xMillz assigned 0xMillz and unassigned reubenstein Aug 3, 2024
@0xMillz 0xMillz mentioned this issue Aug 9, 2024
Merged
@sktbrd
Copy link
Member

sktbrd commented Aug 12, 2024

@0xMillz I think the list checks , right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xMillz 0xMillz

Labels
current scope Part of an active project scope
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@0xMillz @bagelface @sktbrd @reubenstein