Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create endpoint to proxy Goldsky requests #51

Open
bagelface opened this issue Aug 20, 2024 · 0 comments
Open

Create endpoint to proxy Goldsky requests #51

bagelface opened this issue Aug 20, 2024 · 0 comments
Labels
bug Something isn't working current scope Part of an active project scope

Comments

@bagelface
Copy link
Contributor

bagelface commented Aug 20, 2024

Description 🗒️

Currently Goldsky requests are made by frontend components which exposes the key to the public. We want to create a Next API endpoint through which we can proxy requests so that the API key is not exposed.


Details 🏗️

Currently we are using NEXT_PUBLIC_GOLDSKY_BASE_API_URL. Instead we need to make this environment variable private GOLDSKY_BASE_API_URL and accessible only to the backend so that it is not exposed to the public. It would also be smart to rotate the API key since it has been public in production since the creation of this issue.

See TODO comment for context:

#TODO: implement and actually make private (ignore for now)


Acceptance Criteria ☑️

  1. All of the changes described in the "Details" section above are implemented and tested.
  2. Code is clear, clean, and properly documented.
  3. UI changes are sensible and non-regressive.
@bagelface bagelface added bug Something isn't working current scope Part of an active project scope labels Aug 20, 2024
@bagelface bagelface changed the title Create endpoint to proxy for Goldsky requests Create endpoint to proxy Goldsky requests Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working current scope Part of an active project scope
Projects
None yet
Development

No branches or pull requests

1 participant