Replies: 5 comments 10 replies
-
Sounds interesting. Could also add a game verion check to that. I know you can do it manualy, but getting a message that says "Failed to load" seems better than just having to test by hand. |
Beta Was this translation helpful? Give feedback.
-
Thats a good idea, why not |
Beta Was this translation helpful? Give feedback.
-
technically you could just type in at the top of the script in the static section |
Beta Was this translation helpful? Give feedback.
-
I actually went a ways into implementing this |
Beta Was this translation helpful? Give feedback.
-
Just sent a PR with the implementation I started back in the days of this discussion as #798. Would appreciate feedback about how it works here, and about the actual implementation there (or wherever you like really). |
Beta Was this translation helpful? Give feedback.
-
Moved from #642, mostly to test this discussions thing
Currently, there is no way for an app to ask for a minimum Carpet/extension version, and if it's using newer features, it will just fail with something similar to
Function not defined
, or just silently failing to apply some new feature or event, which could derive to app malfunction.Therefore I suggest adding a new map to the
__config()
to prevent an app from loading in case the current Carpet version doesn't apply to the requirements set by the app.It could be something like the following:
It could be based on the modid, and then use FabricLoader's (not Fabric API) version "APIs" (it is located in the
api
package) to check for compatibility directly using mod's metadata parser, so it would allow all operators supported by Fabric in Scarpet. That could be useful, for example, in case it just needs the extension to be present, or if it's using old, removed functions and no one is willing to update it, it could also specify, for instance'carpet' -> '<=1.14.19'
.This could make users not be able to load an app even if it's compatible: Well, actually not, since if they know it's compatible, they also probably know how to delete that from the config. And also, this would tell people to update, which I don't think is bad.
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions