Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or repurpose update suppression related rules #1395

Closed
1 of 2 tasks
altrisi opened this issue Apr 4, 2022 · 2 comments · Fixed by #1445
Closed
1 of 2 tasks

Remove or repurpose update suppression related rules #1395

altrisi opened this issue Apr 4, 2022 · 2 comments · Fixed by #1445

Comments

@altrisi
Copy link
Collaborator

altrisi commented Apr 4, 2022

@FxMorin
Copy link
Contributor

FxMorin commented Apr 4, 2022

You are correct. I will also be removing the code in carpet-fixes related to update suppression, although maybe not for a bit. Currently I have the rule reIntroduceInstantBlockUpdates which brings back the instant block updates using the method that mojang wrote. So I actually still use updateSuppressionCrashFix I can move that into carpet-fixes if you don't want it anymore.
As for updateSuppressionBlock I will add that into carpet-fixes's debug tools, and write a new tool for the new update 'suppression' technique

@altrisi
Copy link
Collaborator Author

altrisi commented Apr 4, 2022

Can always keep the block one if it can be updated for the new method, just the crash fix right now is useless given with only carpet given it can no longer cause a crash (afaik at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants