Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

High memory usage & duration during app installation. #703

Closed
clydesantiago opened this issue Feb 25, 2021 · 2 comments
Closed

High memory usage & duration during app installation. #703

clydesantiago opened this issue Feb 25, 2021 · 2 comments

Comments

@clydesantiago
Copy link
Contributor

clydesantiago commented Feb 25, 2021

Expected Behavior

Optimize query for faster installation of App.

Current Behavior

When you have 100,000+ users, installation process slows down because of redudant query.

Steps to Reproduce

  1. Use https://laravel.com/docs/8.x/telescope for monitoring requests.
  2. Install Shopify App on you shopify
  3. Inspect queries on Laravel Telescope

Context

We are currently using ^12.0 of osiset/laravel-shopify. We also tried upgrading to latest version. The result is the same.

  • Package Version: ^16.0
  • Laravel Version: ^7.0
  • PHP Version: 7.4
  • Vagrant

Failure Logs

Memory usage is 449 MB and Duration is 11 seconds because of query below. Note: this is 100,000+ users
Screenshot at Feb 25 16-58-01

image

@clydesantiago clydesantiago changed the title How to optimize query on installation? High memory usage & duration during app installation. Feb 26, 2021
@clydesantiago
Copy link
Contributor Author

@osiset pull request for the fix #705

@gnikyt
Copy link
Owner

gnikyt commented Feb 26, 2021

Thank you, merged. Will push a patch.

@gnikyt gnikyt closed this as completed Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants