Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when addpkg a Realm with subpaths #1041

Closed
moul opened this issue Aug 10, 2023 · 1 comment · May be fixed by #2155
Closed

Panic when addpkg a Realm with subpaths #1041

moul opened this issue Aug 10, 2023 · 1 comment · May be fixed by #2155
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors

Comments

@moul
Copy link
Member

moul commented Aug 10, 2023

Based on this: #1024 (comment).

We should add a panic("not supported yet") when trying to addpkg a realm with subpaths.

@moul
Copy link
Member Author

moul commented Jun 4, 2024

There is a new direction for this case. Please read #2141 (comment)

Closing in favor of #2141

@moul moul closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors
Projects
Status: Done
Status: 🚀 Needed for Launch
Development

Successfully merging a pull request may close this issue.

1 participant