Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Can't Disconnect Metamask/Coinbase wallet #227

Open
MareenG opened this issue Mar 11, 2021 · 5 comments
Open

Can't Disconnect Metamask/Coinbase wallet #227

MareenG opened this issue Mar 11, 2021 · 5 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working

Comments

@MareenG
Copy link

MareenG commented Mar 11, 2021

Not sure if this intended but I can disconnect all wallets except Metamask.
If I have selected Metamask I only can change my wallet.

Bildschirmfoto 2021-03-11 um 10 33 01

Bildschirmfoto 2021-03-11 um 10 32 46

@alfetopito
Copy link
Contributor

alfetopito commented Mar 11, 2021

Spent a while trying to understand why this isn't there.
It seems it's a feature not available on Metamask MetaMask/metamask-extension#8990
Neither on walletlink for that matter Uniswap/interface#560

So far I haven't found an way to add disconnect for Metamaks in the app UI :/
The only way is to do it on MM itself:

  1. Click on metamask
  2. Click on Connected
  3. Click on the 3 dots
  4. Click on disconnect app

That's not ideal :/

@anxolin
Copy link
Contributor

anxolin commented Mar 12, 2021

Thanks Mareen, we briefly talked about this one, but it was not created as an issue, so good call.

The person asking for a "disconnect solution" end up happy with MetaMask/metamask-extension#8990 (comment) setup. If I understand correctly, he "faked" the disconnection as we use to do in old mesa.

As I understand from Metamask, the disconnection is meant more as a I don't trust the app anymore, so they encourage us to do the disconnection as an internal state of the app thing. I don't necessarily agree with their view, but I we could get by with the other approach.

One thing we could do, is open an issue to Uniswap, in case they implement it themselves.

@anxolin anxolin added the app:CowSwap CowSwap app label Mar 17, 2021
@MareenG
Copy link
Author

MareenG commented Mar 24, 2021

I just noticed it is the same for the Coinbase wallet.
Diconnecting from CowSwap only works via the app

@elena-zh
Copy link

Related to #1496

@elena-zh elena-zh changed the title Can't Disconnect Metamask Can't Disconnect Metamask/Coinbase wallet Jan 31, 2022
@elena-zh elena-zh added the Bug Something isn't working label Jan 31, 2022
@elena-zh
Copy link

The same issue is reproducible when connect to Coinbase wallet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants