Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue with lego dependency for JWT #1452

Closed
3 tasks done
jauderho opened this issue Jul 11, 2021 · 3 comments · Fixed by #1453
Closed
3 tasks done

Security issue with lego dependency for JWT #1452

jauderho opened this issue Jul 11, 2021 · 3 comments · Fixed by #1453

Comments

@jauderho
Copy link

Welcome

  • Yes, I'm using a binary release within 2 latest releases.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

What did you expect to see?

Snyk has identified an issue with github.com/dgrijalva/jwt-go which lego depends on. This has been an identified issue for a while.

What did you see instead?

See https://app.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMDGRIJALVAJWTGO-596515

Fix is to update to a newer version

How do you use lego?

Binary

Reproduction steps

  1. Create Snyk account
  2. Attach Snyk to scan lego code or binary
  3. See warning

Version of lego

lego version 4.4.0 linux/amd64

Logs

lego version 4.4.0 linux/amd64

Go environment (if applicable)

$ go version && go env
# paste output here
@jauderho jauderho added the bug label Jul 11, 2021
@ldez
Copy link
Member

ldez commented Jul 11, 2021

Hello,

This dependency is only used by the azure provider.

$ go mod why github.com/dgrijalva/jwt-go
# github.com/dgrijalva/jwt-go
github.com/go-acme/lego/v4/providers/dns/azure
github.com/Azure/go-autorest/autorest
github.com/Azure/go-autorest/autorest/adal
github.com/dgrijalva/jwt-go

@jauderho
Copy link
Author

jauderho commented Jul 12, 2021

Thanks. Please consider a v4.4.1 point release once fix is merged

@ldez
Copy link
Member

ldez commented Jul 12, 2021

the next version will be v4.5.0, and this bug is a minor bug from the point of view of lego.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants