Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIC SDK 6.0.0.1960 - createTLTSIDCookie missing samesite #2

Open
ustewjt opened this issue Sep 15, 2020 · 1 comment
Open

UIC SDK 6.0.0.1960 - createTLTSIDCookie missing samesite #2

ustewjt opened this issue Sep 15, 2020 · 1 comment

Comments

@ustewjt
Copy link

ustewjt commented Sep 15, 2020

New parameter added to setCookie function is not used and no method to set

setCookie: function (cookieName, cookieValue, maxAge, path, domain, secure, samesite) {

     function createTLTSIDCookie() {
        var cookieValue = generateTLTSID(),
            secure = !!moduleConfig.secureTLTSID;

        // Set the session cookie
        utils.setCookie(tltCookieName, cookieValue, undefined, undefined, undefined, secure);

Would expect this code:

     function createTLTSIDCookie() {
        var cookieValue = generateTLTSID(),
            secure = !!moduleConfig.secureTLTSID,
            samesite = moduleConfig.samesite;

        // Set the session cookie
        utils.setCookie(tltCookieName, cookieValue, undefined, undefined, undefined, secure, samesite);

@ohernandezIBM
Copy link
Contributor

Thank you bring this to our attention, this will be addressed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants