Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request is broken #11105

Closed
2 of 7 tasks
kraszied opened this issue Apr 17, 2020 · 3 comments
Closed
2 of 7 tasks

Pull request is broken #11105

kraszied opened this issue Apr 17, 2020 · 3 comments

Comments

@kraszied
Copy link

  • Gitea version (or commit ref): 1.11.4
  • Git version: 2.24.0
  • Operating system: Windows 10
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

If a pull request (PR) is created and then a new commit is pushed to the source (head) branch the PR became broken. The newly pushed commit doesn’t appear in the PR and head branch appears as "deleted". The branch protection is set to the destination branch. In this repository all created PRs behave the same independently which are the source and destination branches. In our other repository this error never comes. This situation prevents us to fulfill an effective code review, because we need to open a new PR after every newly pushed commit related to the review.

Here is a link to my ticket on our forum: https://discourse.gitea.io/t/pull-request-is-broken/2092

@filipnavara
Copy link
Contributor

Check that the git hooks are executing properly. This exact problem was happening on our installation and that was the root cause.

@kraszied
Copy link
Author

@filipnavara thank you for your info! Actually we don't have any git hooks but updating the Gitea version and regeneration of SSH keys (Update the '.ssh/authorized_keys' file with Gitea SSH keys. (Not needed for the built-in SSH server.) on dashboard) are solved our problem.

@filipnavara
Copy link
Contributor

Gitea relies on git hooks that are installed in the repositories. If they are not present then it will break in this exact way. When you create the repository in Gitea these hooks are automatically installed but someone might have broken them during some maintenance operation.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants