Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Viewed" option in Pull Requests #11730

Closed
VishwasShashidhar opened this issue Jun 2, 2020 · 3 comments · Fixed by #19007
Closed

Support "Viewed" option in Pull Requests #11730

VishwasShashidhar opened this issue Jun 2, 2020 · 3 comments · Fixed by #19007
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Milestone

Comments

@VishwasShashidhar
Copy link

  • Gitea version (or commit ref): 1.8.2
  • Git version: N/A
  • Operating system: N/A

Description

For Pull Requests that contain a lot of files being changed / added, it helps to have an option (like in GitHub) where in you can mark the file as viewed and review the remaining files in multiple sessions.
...

Screenshots

Screenshot 2020-06-02 at 12 42 25

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jun 3, 2020
@stale
Copy link

stale bot commented Aug 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 2, 2020
@a1012112796
Copy link
Member

ping :)

@stale stale bot removed the issue/stale label Aug 2, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 4, 2020
@6543
Copy link
Member

6543 commented Jan 26, 2021

for the Backend Part who notice changes to files, there are 2 TODOs:

  • extend checkIfPRContentChanged to return file list
  • move AddTestPullRequestTask into queue

revs:
https://github.com/go-gitea/gitea/blob/master/services/pull/pull.go#L233

gitea/services/pull/pull.go

Lines 368 to 378 in a598877

for diffBeforeLines.Scan() && diffAfterLines.Scan() {
if strings.HasPrefix(diffBeforeLines.Text(), "index") && strings.HasPrefix(diffAfterLines.Text(), "index") {
// file hashes can change without the diff changing
continue
} else if strings.HasPrefix(diffBeforeLines.Text(), "@@") && strings.HasPrefix(diffAfterLines.Text(), "@@") {
// the location of the difference may change
continue
} else if !bytes.Equal(diffBeforeLines.Bytes(), diffAfterLines.Bytes()) {
return true, nil
}
}

@lunny lunny added this to the 1.17.0 milestone May 8, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants