Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image diff has 0 width/height images #15920

Closed
silverwind opened this issue May 18, 2021 · 1 comment · Fixed by #14867
Closed

Image diff has 0 width/height images #15920

silverwind opened this issue May 18, 2021 · 1 comment · Fixed by #14867
Labels
type/bug

Comments

@silverwind
Copy link
Member

silverwind commented May 18, 2021 •
edited
Loading

Seems like image diff is currently broken, all images have inline styles with width: 0; height: 0. I think the JS calculations go wrong somewhere. Also, I think default view mode should be image diff.

Example: https://try.gitea.io/silverwind/updates/commit/3d80fab2f8ee1d7bca1b7cff4f242461424866f8

cc: @KN4CK3R
@KN4CK3R
Copy link
Member

KN4CK3R commented May 19, 2021

That's caused by the "file view toggle" from #14661 and already fixed in #14867. As 1.14.2 still works I would wait until the PR with the fix gets merged.

@KN4CK3R KN4CK3R mentioned this issue May 19, 2021
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Image Diff for SVG files KN4CK3R/gitea
2 participants
@silverwind @KN4CK3R