Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Comment Creation 500 in Gitea Version 1.21.3 #29063

Closed
Menah3m opened this issue Feb 6, 2024 · 5 comments
Closed

Code Review Comment Creation 500 in Gitea Version 1.21.3 #29063

Menah3m opened this issue Feb 6, 2024 · 5 comments
Labels
Milestone

Comments

@Menah3m
Copy link

Menah3m commented Feb 6, 2024

Description

I am using Gitea version 1.21.3, and when creating a code review comment, an error occurs with the following message:

2024/01/30 14:27:51 .../context_response.go:86:HTML() [E] Render failed: failed to render template: repo/diff/conversation, error: template error: builtin(bindata):repo/diff/conversation:1:16 : executing "repo/diff/conversation" at <index .comments 0>: error calling index: reflect: slice index out of range
image

I noticed that this issue has been fixed in #28351 by the official team, but it seems the fix is not effective. Could you please help investigate how to resolve this issue?

Gitea Version

1.21.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

bug.mov

Git Version

2.39

Operating System

CentOS7

How are you running Gitea?

Kubernetes cluster

Database

PostgreSQL

@lunny
Copy link
Member

lunny commented Feb 6, 2024

Can you try to upgrade to 1.21.5?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 6, 2024

1.21.5 doesn't help.

The root problem is that your PR is closed and outdated, so #29049 might help (in next release 1.21.6 , aka nightly at the moment)

The better approach could be #29050 , but it needs more reviews.

@lunny lunny added this to the 1.21.6 milestone Feb 6, 2024
@lunny
Copy link
Member

lunny commented Feb 19, 2024

I think this has been fixed by #29086 @wxiaoguang ?

@wxiaoguang
Copy link
Contributor

Yes, but 1.21.6 hasn't been released yet.

@lunny lunny closed this as completed Feb 19, 2024
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants