Take back control of git-hooks (aka The Great Migration)

[bkcsoft]

• Gitea version (or commit ref): c8f300b
• Git version: 2.10.2

This is in no way related to gogs/gogs#1623 ...

Basically I wanna move most of the git-related callbacks into git-hooks, this would however break all existing support for custom git-hooks, but it will make it easier to implement features such as #302 #32 #8 and would fix #218 without actually having to fix it (since the bug is that Gitea have to duplicate the input-data to shove one down gits throat and the other into what is essentially .git/hooks/update 😒 )

thoughts?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/39736071-take-back-control-of-git-hooks-aka-the-great-migration?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

[tboerger]

I would also take the control of the hooks but that doesn't directly solve the mentioned issues :)

[strk]

Breaking existing deploys won't help adoption of Gitea, unless automatic adaption of hooks is provided.

[tboerger]

This is intended for 2.0.0 where breaking changes will be totally fine.

[tboerger]

As this will introduce real breaking changes I have created and assigned the 2.x.x milestone.

[bkcsoft]

@strk possible migrations involve calling user provided hooks at the end of giteas hooks, which should be fairly easy to make a migration for 🙂

@tboerger it says "make it easier to implement" not "fix" 😛 the only thing it will automagically fix is #218 which only exists as a bug since we're not using git-hooks for what git-hooks was created for 😆

[adymitruk]

what's the workaround for getting a custom update hook? Add this to the repos' update hooks?

if [ -e hooks/update.custom ]; then bash hooks/update.custom "$@"; fi || exit
# the regular gitea line

[lunny]

I don't think this should be a v2.x.x issue. It should be fixed ASAP.

[bkcsoft]

@lunny potential breakage, loads of migrations and backwards compatibility. In my book it belongs in a major-release 🙂

[tboerger]

Somebody can build a POC than we can see if it should work without breaking installations or not :)

[bkcsoft]

I'll have a look at cherry-picking and correcting a few things from gogs/gogs@039dc33 during the weekend 🙂

[lunny]

resolved by #1006