Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook issues send more event #5364

Closed
2 of 7 tasks
RelicOfTesla opened this issue Nov 20, 2018 · 4 comments · Fixed by #5365
Closed
2 of 7 tasks

Webhook issues send more event #5364

RelicOfTesla opened this issue Nov 20, 2018 · 4 comments · Fixed by #5365
Labels
Milestone

Comments

@RelicOfTesla
Copy link

RelicOfTesla commented Nov 20, 2018

  • Gitea version (or commit ref):
  • Git version:
  • Operating system: windows
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

  1. Set WebHook to [https://oapi.dingtalk.com/robot/send?access_token=xxxxxx]
  2. Click [Issues] And input content.
  3. Set [Assignees], more peoples(>=3)
  4. Create issues
  5. My DingTalk receive 4+ message, Only one second!.
    I see [Webhook]->[Recent Deliveries]
actionCard4:   Issue opened:
actionCard3:   Issue assigned to C
actionCard2:   Issue assigned to B
actionCard1:   Issue assigned to A

...

Screenshots

_20181120195117

@adelowo
Copy link
Member

adelowo commented Nov 20, 2018

I think this is the expected result as they are technically individual events although batched together as one.

  • Create issue
  • Assign user A.
  • Assign user B.
  • Assign user C.

@RelicOfTesla
Copy link
Author

RelicOfTesla commented Nov 20, 2018

Please note the time, if this WEBHOOK is just a message notification, or mail push. Then, it will result in the newly created work order, running out of multiple records at once. If more people choose, it may even send dozens of e-mails repeatedly.

@lunny
Copy link
Member

lunny commented Nov 20, 2018

@adelowo this should be a bug.

@adelowo
Copy link
Member

adelowo commented Nov 20, 2018

Please note the time, if this WEBHOOK is just a message notification, or mail push. Then, it will result in the newly created work order, running out of multiple records at once. If more people choose, it may even send dozens of e-mails repeatedly.

Oh I get this, sorry for the misunderstanding.

@lunny 👍

@lunny lunny added this to the 1.6.0 milestone Nov 21, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants