Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track issue changes, join labels #834

Closed
jeppech opened this issue Feb 3, 2017 · 13 comments
Closed

Track issue changes, join labels #834

jeppech opened this issue Feb 3, 2017 · 13 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@jeppech
Copy link

jeppech commented Feb 3, 2017

When changing/adding/removing multiple labels at the same time, each "event" is showing on their own seperate line, as show below
Multiple tags

Wouldn't it be more cleaner to join all the events, so they're represented in one line instead, like this:
one line labels


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jeppech
Copy link
Author

jeppech commented Feb 3, 2017

The initial feature PR is #788

@lunny lunny added this to the 1.2.0 milestone Feb 3, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 3, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Feb 12, 2017

Could this be done in the UI? having something that reads the event-lines and checks username + "added"/"removed" + time_since and concatenating them?

@lunny
Copy link
Member

lunny commented Feb 12, 2017

If we changed more than two labels, how to display on the UI?

@bkcsoft
Copy link
Member

bkcsoft commented Feb 12, 2017

$(".event").each(function(index) {
	curr = $(this);
	p = curr.prev();
	if (p != undefined && p.hasClass("event")) {
		event = "added"
		if ($("span.text", p).text().includes("removed")) {
			event = "removed"
		}
		if ($("span > .time-since", p).text() == $("span > .time-since", curr).text() &&
			$("span.text", curr).text().includes(event)) {
			$("span > .label", curr).after($("span > .label", p));
			p.remove();
		}
	}
});

Screenshot:
2017-02-12-075434_1916x1036_scrot

Edit: The above code is ugly AF and only serves as a proof-of-concept. If someone makes a PR for this, clean up the code first 😂

@bkcsoft
Copy link
Member

bkcsoft commented Feb 12, 2017

Hint: If the event-element has class="event label add" instead this would be much easier and cleaner :)

@bkcsoft
Copy link
Member

bkcsoft commented Feb 12, 2017

And the above code doesn't join if the time-since is different

2017-02-12-080425_1916x1036_scrot

@jeppech
Copy link
Author

jeppech commented Feb 13, 2017

This looks good

@bkcsoft
Copy link
Member

bkcsoft commented Feb 14, 2017

We could also turn them into Vue-components now that we use Vue in another place :trollface:

@mbger
Copy link

mbger commented Mar 5, 2018

Any plans/updates on this one? The current instance over at try gitea io still has the same behavior.

issuelabels

@lunny
Copy link
Member

lunny commented Mar 5, 2018

@mbger currently nobody working on this.

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 7, 2019
@tonivj5
Copy link
Contributor

tonivj5 commented Feb 7, 2019

Unstale 👍

@stale stale bot removed the issue/stale label Feb 7, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 7, 2019
@techknowlogick
Copy link
Member

this was recently merged, can't find PR for it though right now, but you can see that on try.gitea.io it works.

@lafriks lafriks removed this from the 1.x.x milestone Dec 9, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

7 participants