Having issue with accessing directory inside a repository having same name as username

[hiteshnayak305]

• Gitea version (or commit ref): master 20/10/2019
• Git version: git version 2.23.0.windows.1
• Operating system: windows 10 18999 build
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL) https://try.gitea.io/hiteshnayak305/hiteshnayak305
  • No
  • Not relevant
• Log gist: https://gist.github.com/hiteshnayak305/3421c3aa04cafb8a15e540a79936df61

Description

accessing folders inside repository with same name as user name gives error 500.
...

Screenshots

[mrsdizzie]

Migrating this to view logs suggest problem is unrelated to username but nil reference with new GPG code added recently:

2019/10/20 16:37:36 ...les/context/panic.go:35:1() [E] PANIC:: runtime error: invalid memory address or nil pointer dereference
        /usr/local/opt/go/libexec/src/runtime/panic.go:82 (0x40447d0)
                panicmem: panic(memoryError)
        /usr/local/opt/go/libexec/src/runtime/signal_unix.go:390 (0x40445ff)
                sigpanic: panicmem()
        /Users/mrsdizzie/.go/src/code.gitea.io/gitea/models/gpg_key.go:684 (0x4bb116c)
                ParseCommitWithSignature: log.Error("Error getting default public gpg key: %v", err)
        /Users/mrsdizzie/.go/src/code.gitea.io/gitea/routers/repo/view.go:184 (0x4f3225f)
                renderDirectory: ctx.Data["LatestCommitVerification"] = models.ParseCommitWithSignature(latestCommit)
        /Users/mrsdizzie/.go/src/code.gitea.io/gitea/routers/repo/view.go:455 (0x4f37882)
                renderCode: renderDirectory(ctx, treeLink)
        /Users/mrsdizzie/.go/src/code.gitea.io/gitea/routers/repo/view.go:395 (0x4f36d91)
                Home: renderCode(ctx)

[zeripath]

OK, I think I understand what's happened here. The stack trace implies that L684 here is the cause - but actually it's wrong the cause is coming from L685

gitea/models/gpg_key.go

Lines 682 to 685 in c8f3146

	defaultGPGSettings, err := c.GetRepositoryDefaultPublicGPGKey(false)
	if err != nil {
	log.Error("Error getting default public gpg key: %v", err)
	} else if defaultGPGSettings.Sign {

The defaultGPGSettings is nil. But how can that be?

gitea/modules/git/commit.go

Lines 503 to 508 in c8f3146

	func (c *Commit) GetRepositoryDefaultPublicGPGKey(forceUpdate bool) (*GPGSettings, error) {
	if c.repo == nil {
	return nil, nil
	}
	return c.repo.GetDefaultPublicGPGKey(forceUpdate)
	}

c.repo must be nil so this code will return nil, nil.

[zeripath]

Now c.repo being nil implies it is an unattached commit. It absolutely should be associated with a repository otherwise we cannot examine whether it was signed by the default key.

So there's another bug that this is revealing in:

gitea/modules/git/commit_info.go

Line 15 in c8f3146

func (tes Entries) GetCommitsInfo(commit *Commit, treePath string, cache LastCommitCache) ([][]interface{}, *Commit, error) {

In particular:

gitea/modules/git/commit_info.go

Lines 67 to 76 in c8f3146

	// Retrieve the commit for the treePath itself (see above). We basically
	// get it for free during the tree traversal and it's used for listing
	// pages to display information about newest commit for a given path.
	var treeCommit *Commit
	if treePath == "" {
	treeCommit = commit
	} else if rev, ok := revs[""]; ok {
	treeCommit = convertCommit(rev)
	}
	return commitsInfo, treeCommit, nil

Where at L74 the coerced commit doesn't gain a reference to the underlying repository
So that needs fixing and although L685 is responsible for the panic it was a good thing because we'd have great difficulty tracking down this bug without it!