Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG Signing: let user provide signature #9723

Open
zeripath opened this issue Jan 12, 2020 · 2 comments
Open

GPG Signing: let user provide signature #9723

zeripath opened this issue Jan 12, 2020 · 2 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/commit-signing type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@zeripath
Copy link
Contributor

Although we now have a way of automatically signing commits, these will be signed with a key held on the server.

Some users might prefer to sign things themselves without having their private key on the server but would still want to sign automated commits.

This could be supported by presenting to the user the payload of a commit to sign which they could respond with a valid signature which is to be embedded in the commit.

This would require some changes to our temporary pushing repositories as the commits would need to hang around or be recalculated each time. The user probably would also need some way of checking that the commit they're signing actually represents what they think they're signing.

Assuming such problems are not insurmountable two immediate extensions come to mind:

  • Add openpgpjs to streamline the signature process
  • Allow re-signing of a series of commits
@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 12, 2020
@stale
Copy link

stale bot commented Mar 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 12, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 12, 2020
@stale stale bot removed the issue/stale label Mar 12, 2020
@lunny
Copy link
Member

lunny commented Feb 18, 2021

#14483 may resolve the problem. A private gpg key could be stored in secrets manager and be used when necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/commit-signing type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

2 participants