prefer defer resp.Body.Close to avoid leaks on subsequent errors

go-jira · May 25, 2019 · 181bd74 · 181bd74
1 parent f6809e3
commit 181bd74
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/search.go b/search.go
@@ -91,6 +91,7 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search
 		if err != nil {
 			return nil, err
 		}
+		defer resp.Body.Close()
 
 		if resp.StatusCode != 200 {
 			return nil, responseError(resp)
@@ -107,7 +108,6 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search
 		if len(issues) == results.Total || results.Total == 0 {
 			break
 		}
-		resp.Body.Close()
 	}
 	results.Issues = issues
 	return results, nil