Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka transport implementation #1209

Closed
alebabai opened this issue Jan 6, 2022 · 4 comments
Closed

Kafka transport implementation #1209

alebabai opened this issue Jan 6, 2022 · 4 comments

Comments

@alebabai
Copy link
Contributor

alebabai commented Jan 6, 2022

What would you like?

Hi,

I've implemented module with Apache Kafka transport abstractions for use with go-kit.
It follows common go-kit code style, has documentation and examples (separate modules).

If you find this interesting and useful, it would be great if you could leave a link to it somewhere.

For community: any help, advice, contribution is appreciated.

Thanks.

https://github.com/alebabai/go-kit-kafka

@sagikazarmark
Copy link
Contributor

I don't think there is a section in the readme for third-party transport implementations, so your may be the first one. I'd say feel free to open a PR and add it somewhere in the readme (maybe below or above the code generator section).

@peterbourgon do you have any preference?

@Reasno
Copy link
Contributor

Reasno commented Jan 7, 2022

@alebabai while I appreciate the effort in making this cleanly written and well-documented repo, I think it treats Kafka as a pub/sub, instead of an RPC transport. All other modules in go-kit focus on Request-Response pattern only, including AMQP.

@alebabai
Copy link
Contributor Author

alebabai commented Jan 7, 2022

@Reasno Hi, thanks for feedback.
AMPQ and Nats here are implemented as a pub/sub with RPC concepts (endpoints, request/response), my transport is inspired by them and implemented same way using same principles.

@peterbourgon
Copy link
Member

We're not merging new transports, but I'm happy to add a section to the README for this. I think there are probably several more that warrant inclusion. Please open a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants