-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support connecting to BrightData Scraping Browsers #1092
Comments
Please add a valid generated by check-issue |
I am using the las version of go-rod (v0.116.2). |
Have you checked this example file? You can use other websocket lib to do any kind of auth you like: rod/lib/examples/custom-websocket/main.go Lines 26 to 49 in 8ffcc0f
|
About the error string, you can also use your customized websocket to convert the error to a number: // Read ...
func (w *WebSocket) Read() ([]byte, error) {
b, err := wsutil.ReadServerText(w.conn)
// parse b, and replace the string to int, then encode it to json bytes
...
return normalized, err
} I think the error string is a bug of BrightData, we should raise an issue about it. It should follow the cdp protocol definition. |
I'd like to use scalable browser infrastructure services, such as the BrightData Scraping Browser, which integrate well with Puppeteer. But, I have encountered some issues when trying to use these services with go-rod. I would like to request the following enhancements to improve compatibility:
1. WebSocket Authentication:
The connection to these services’ WebSocket requires authentication (e.g., wss://user:pass@host:9222). However, go-rod does not currently send the necessary authentication headers, which I think are not defined on any WebSocket standard.
Through my research, I discovered that authentication is performed using Basic tokens. I have implemented a working solution to inject the Authorization header. However, I am unsure if this is the optimal place to inject it. If this solution aligns with the project's direction, I am willing to submit a PR with my implementation.
2. Less Restrictive WebSocket Response Handling:
The services sometimes send responses that deviate from the expected go-rod Response structure, causing panics due to unmarshalling failures. Specifically, the Error struct expects an integer Code, but some responses include a string (e.g., "navigate_limit").
The Response structure is defined this way:
And Brightdata is sending to me struct that panic, like this
To make go-rod more compatible, it may be necessary to relax the strictness of the standard for the Error struct. I would appreciate guidance on the best approach to achieve this flexibility. If you agree with this, I am happy to work on the implementation with a bit of guidance.
The text was updated successfully, but these errors were encountered: