feat!: api file export #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitpshr
force-pushed
the
feat/raw-response
branch
from
032a80a
to
22a03d0
Compare
bitpshr
force-pushed
the
feat/api-file-export
branch
from
7041bb6
to
03c9dfc
Compare
bitpshr
force-pushed
the
feat/api-file-export
branch
from
03c9dfc
to
28243ac
Compare
|
Rebased and ready for a pass whenever there's time. Will be great to get this into a prerelease for some additional battle-testing. |
|
@bitpshr were we waiting on additional protections on the API side? |
|
The API is already throttling export requests, so I think we should be OK. |
tommoor
reviewed
Jan 10, 2020
|
Thanks for the review so far @tommoor. An |
bitpshr
force-pushed
the
feat/api-file-export
branch
from
393b893
to
9b9045f
Compare
|
Any thoughts on this type of progress exposure @tommoor? No major rush here, but this PR blocks a few internal and external initiatives. Always happy to hop on a call since it's a bit of a dense PR. |
tommoor
reviewed
Jan 16, 2020
tommoor
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds file export functionality to the API transport.
References #182