Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add ValidationError class #301

Merged
merged 3 commits into from
Jul 29, 2020
Merged

fix: Add ValidationError class #301

merged 3 commits into from
Jul 29, 2020

Conversation

tommoor
Copy link
Contributor

@tommoor tommoor commented Jul 27, 2020 •
edited
Loading

Validation errors are one of the most common error types, yet we weren't giving it it's own class/handler.

Also no longer throws MultiError when only a single transport is used.

closes #279

@tommoor tommoor marked this pull request as ready for review July 27, 2020 23:15
berezovskyicom
berezovskyicom approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@berezovskyicom berezovskyicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm👍

@tommoor tommoor requested a review from rickharris July 28, 2020 21:10
@tommoor
Copy link
Contributor Author

tommoor commented Jul 29, 2020

review please

amccloud
amccloud approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@amccloud amccloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tommoor tommoor merged commit 2d4f9c5 into master Jul 29, 2020
@tommoor tommoor deleted the fix/validation-error branch July 29, 2020 17:46
@tommoor tommoor mentioned this pull request Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berezovskyicom berezovskyicom berezovskyicom approved these changes

@amccloud amccloud amccloud approved these changes

@rickharris rickharris Awaiting requested review from rickharris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not throw MultiError unless necessary
3 participants
@tommoor @amccloud @berezovskyicom