Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goaop/parser-reflection dependency to 2.0+ #403

Closed
ddinchev opened this issue Dec 27, 2018 · 6 comments
Closed

Update goaop/parser-reflection dependency to 2.0+ #403

ddinchev opened this issue Dec 27, 2018 · 6 comments

Comments

@ddinchev
Copy link

I'm trying to use a new version of phpstan which requires nikic/php-parser:^4.0. However, I'm also using AspectMock, that depends on this framework - goaop/framework:~2.2, which depends on goaop/parser-reflection:~1.4, which uses nikic/php-parser:^3.0 🙃

I saw that you already released goaop/parser-reflection:2.0.0 which uses the latest php-parser (4.0) - would it be relatively painless to let goaop/framework use that latest version of parser-reflection, hopefully without introducing BC and without need to release a major new version of the framework?

@lisachenko
Copy link
Member

Hi, @ddinchev

I will check, if it's possible to do for 2.x version of framework.

@lisachenko
Copy link
Member

I've pushed 925f01d into the 2.x branch with new version of goaop/parser-reflection, could you please try to require goaop/framework:2.x-dev? If everything will work for you, I'll prepare a release for that.

@ddinchev
Copy link
Author

ddinchev commented Jan 7, 2019

Thanks a lot for this, can confirm that it is working fine for me! 👍

@lisachenko
Copy link
Member

I'm not sure if it's ok to release it as 2.3.0, because it breaks BC, as PHP>=7.0 will be required for 2.x branch for now. 🤔

@lisachenko lisachenko added this to the 2.x milestone Jan 13, 2019
@lisachenko
Copy link
Member

Let's proceed with 2.3.0, but im emergency case, I'll revert this and release 2.3.1 with previous version.

@lisachenko
Copy link
Member

Resolved in 925f01d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants