-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update goaop/parser-reflection
dependency to 2.0+
#403
Comments
Hi, @ddinchev I will check, if it's possible to do for 2.x version of framework. |
I've pushed 925f01d into the 2.x branch with new version of |
Thanks a lot for this, can confirm that it is working fine for me! 👍 |
I'm not sure if it's ok to release it as 2.3.0, because it breaks BC, as PHP>=7.0 will be required for 2.x branch for now. 🤔 |
Let's proceed with 2.3.0, but im emergency case, I'll revert this and release 2.3.1 with previous version. |
Resolved in 925f01d |
I'm trying to use a new version of
phpstan
which requiresnikic/php-parser:^4.0
. However, I'm also using AspectMock, that depends on this framework -goaop/framework:~2.2
, which depends ongoaop/parser-reflection:~1.4
, which usesnikic/php-parser:^3.0
🙃I saw that you already released
goaop/parser-reflection:2.0.0
which uses the latestphp-parser
(4.0) - would it be relatively painless to letgoaop/framework
use that latest version ofparser-reflection
, hopefully without introducing BC and without need to release a major new version of the framework?The text was updated successfully, but these errors were encountered: