Using Main for PRs instead of Development. #132
Replies: 3 comments 1 reply
-
Totally agree. Actually, that is what I want to say but just postponed until we start discussing v1. Not directly related, one another idea of mine is that I think just making the current version as v1 in near future after polishing it if there are important issues to be fixed, freezing them unless any security bug, and start new jump as v2 and focusing all our effort on the new version would be a most feasible strategy for us. |
Beta Was this translation helpful? Give feedback.
-
I'm fine with dropping the development branch in favor of working directly on main. The only drawback I see is that then it might be harder to create release notes for every new version, but maybe we can do that also based on the diff between the latest tag and current instead of main and develop? |
Beta Was this translation helpful? Give feedback.
-
Conclusion of the DiscussionCongratulations! The actions were taken and now we deprecated the |
Beta Was this translation helpful? Give feedback.
-
Now that Go modules have generalized I wonder if we should keep requesting PR's to development. I remember that
master
branch needed to be untouched because before Go modules the latest commit was what applications used to build their apps, however, now that we have modules applications no longer use our main branch as the base for their development and hence it could be moving as we merge PR's without affecting the compilation/use of Buffalo, unless they explicitly update to the version/commit in main.The main benefit I see from moving to use main instead of development is that we would reduce one step from our release process. I have not thought about any negative effect besides GOPATH based development but would love to read your thoughts.
cc @gobuffalo/all @sio4 @fasmat
Beta Was this translation helpful? Give feedback.
All reactions