Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect enumeration mappings #29

Open
paulourio opened this issue Jul 8, 2023 · 0 comments
Open

Incorrect enumeration mappings #29

paulourio opened this issue Jul 8, 2023 · 0 comments

Comments

@paulourio
Copy link

There are several enums with incorrect mappings in Go.

At /zetasql/parser/ast_enums.proto we types such as ASTWindowFrameEnums and several others that actually start at 1.
They all have a comment "0 reserved for future".
Meanwhile, all definitions in Go start at zero, so many of these enums are shifted by one: for ASTWindowFrameEnums, in Go UnboundedPrecedingType has value 0 but it should be 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant