Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-165 #215

Closed
jmank88 opened this issue Jan 21, 2019 · 5 comments
Closed

ERC-165 #215

jmank88 opened this issue Jan 21, 2019 · 5 comments

Comments

@jmank88
Copy link
Contributor

jmank88 commented Jan 21, 2019

ERC-165 "Creates a standard method to publish and detect what interfaces a smart contract implements."

Explorer should check if a contract implements 165, and if so it should utilize supportsInterface(interfaceID) to check for any common interfaces that can be used (e.g. ERC-20).

Related to (and probably blocking) #212

@jmank88
Copy link
Contributor Author

jmank88 commented Jan 23, 2019

Each call costs up to 30,000 gas, so this may not be a scalable option.

@bergauz
Copy link
Contributor

bergauz commented Mar 5, 2019

@jmank88 extracted interfaces from bytecode
b9d4b9a

@jmank88
Copy link
Contributor Author

jmank88 commented Mar 5, 2019

b9d4b9a

@bergauz This is an alternative to ERC-165, correct? We can't actually use it for free?

@bergauz
Copy link
Contributor

bergauz commented Mar 27, 2019

@jmank88 @treeder since we are getting interfaces from bytecode -> #242, if needed we can store interfaces that contract supports to db and show them in contract page, smth like #176

@bergauz
Copy link
Contributor

bergauz commented Apr 3, 2019

@jmank88 @treeder closing?

@jmank88 jmank88 closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants