Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic GO-721 / ERC-721 support #225

Closed
treeder opened this issue Feb 1, 2019 · 13 comments
Closed

Add automatic GO-721 / ERC-721 support #225

treeder opened this issue Feb 1, 2019 · 13 comments
Assignees
Labels
enhancement New feature or request

Comments

@treeder
Copy link
Contributor

treeder commented Feb 1, 2019

Detect GO-721 contracts and display all the appropriate information.

Should also be able to look at a particular item and view all the metadata about it along with the image of it. See https://docs.opensea.io/docs/2-adding-metadata for more information.

@treeder
Copy link
Contributor Author

treeder commented Mar 5, 2019

@bergauz where are we at with this?

@treeder treeder added the enhancement New feature or request label Mar 5, 2019
@treeder
Copy link
Contributor Author

treeder commented Mar 26, 2019

For the particular item, after searching for it, have the URL be something like:

https://explorer.gochain.io/token/CONTRACT_ADDRESS/asset/TOKEN_ID

TOKEN_ID being the particular assets ID. The page to view the item would called tokenURI(tokenID) to get the metadata, then display it along with the image in the metadata.

@treeder
Copy link
Contributor Author

treeder commented Mar 26, 2019

BTW, on testnet and mainnet, this is a live contract address with some assets:

0x29af464A1099Ddf11C5770d8E05CBa18cAeF47d4

@bergauz
Copy link
Contributor

bergauz commented Mar 26, 2019

For the particular item, after searching for it, have the URL be something like:

https://explorer.gochain.io/token/CONTRACT_ADDRESS/asset/TOKEN_ID

TOKEN_ID being the particular assets ID. The page to view the item would called tokenURI(tokenID) to get the metadata, then display it along with the image in the metadata.

@treeder does address need to be exactly as you wrote? since we use addr/address instead of token can it be https://explorer.gochain.io/address/CONTRACT_ADDRESS/asset/TOKEN_ID

@treeder
Copy link
Contributor Author

treeder commented Mar 26, 2019

That's how etherscan does it, good to be consistent with the norm: https://etherscan.io/token/0x06012c8cf97bead5deae237070f9587f8e7a266d#inventory

Could we alias token? (but only work if it's a token contract?)

@bergauz
Copy link
Contributor

bergauz commented Mar 26, 2019

@treeder yes

@bergauz
Copy link
Contributor

bergauz commented Mar 27, 2019

@treeder is there's metadata json structure standard? cause what i've checked here https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md and https://docs.opensea.io/docs/2-adding-metadata are different

@treeder
Copy link
Contributor Author

treeder commented Mar 27, 2019

One's in JSON schema format so it looks different, but the main ones are the following and the JSON will look like this, so just display these 3 values.

{
  "name": "Dave Starbelly",
  "description": "Friendly OpenSea Creature that enjoys long swims in the ocean.", 
  "image": "https://storage.googleapis.com/opensea-prod.appspot.com/puffs/3.png"
}

@bergauz
Copy link
Contributor

bergauz commented Apr 3, 2019

@treeder @jmank88 we can close issue, right?

@jmank88
Copy link
Contributor

jmank88 commented Apr 3, 2019

IMHO the token page is not accessible enough. It should at least be linked from the normal contract page, or better yet merged together with it.

@treeder
Copy link
Contributor Author

treeder commented Apr 3, 2019

Agree, need an obvious way to access it from main contract page (or merge like @jmank88 said). If merged, keep both URLs though to conform with etherscan.

@treeder
Copy link
Contributor Author

treeder commented Apr 13, 2019

@bergauz let's merge /token/ and /addr/

They both have token like information, but one has different stuff than the other. Let's just make them the same page, make the /token an alias for /addr and take the extra things like the "Token type" chips and things from /token and add them to /addr.

@bergauz
Copy link
Contributor

bergauz commented May 11, 2019

since support added, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants