Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

feat: add support for dataFrom #196

Merged
merged 9 commits into from
Nov 5, 2019
Merged

feat: add support for dataFrom #196

merged 9 commits into from
Nov 5, 2019

Conversation

Flydiverny
Copy link
Member

@Flydiverny Flydiverny commented Nov 5, 2019 •
edited
Loading

Adds dataFrom as discussed here #94 (comment)

alternative to #189 and includes fix for #184

Allows this:

apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: postgres-credentials
secretDescriptor:
  backendType: secretsManager
  dataFrom:
  - /development/postgres/credentials
  - /development/api/credentials
  data:
  - key: /development/auth/secret
    name: authSecret

Flydiverny
Flydiverny commented Nov 5, 2019
View reviewed changes
lib/backends/kv-backend.js
(Buffer.from(`${plainValue}`, 'utf8')).toString('base64')
])

return Object.fromEntries(encodedEntries)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requires node 12 🎉

silasbw
silasbw approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@silasbw silasbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad 🔥!

lib/backends/kv-backend.js Show resolved Hide resolved
lib/backends/kv-backend.js Outdated
* @returns {Promise} Promise object representing secret property values.
*/
_fetchSecretPropertyValues ({ externalData, roleArn }) {
return Promise.all(externalData.map(async secretProperty => {
_fetchSecretPropertyValues ({ data, roleArn }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go ahead and rename this _fetchDataValues?

@iAnomaly iAnomaly mentioned this pull request Nov 5, 2019
Closed
@Flydiverny Flydiverny merged commit 90f01c5 into external-secrets:master Nov 5, 2019
@Flydiverny Flydiverny deleted the feat/data-from branch November 5, 2019 19:58
This was referenced Nov 5, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasbw silasbw silasbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flydiverny @silasbw