Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bindings generation fast and IDE-friendly #789

Open
Bromeon opened this issue Sep 30, 2021 · 0 comments
Open

Make bindings generation fast and IDE-friendly #789

Bromeon opened this issue Sep 30, 2021 · 0 comments
Labels
bug c: bindings Component: GDNative bindings (mod api) c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem
Milestone

Comments

@Bromeon
Copy link
Member

Bromeon commented Sep 30, 2021

The current approach of writing the entire bindings into a single file generated.rs seems to be fast regarding compile/link times, but causes problems with the CLion IDE due to the large file size: intellij-rust/intellij-rust#6134

The gdnative-bindings crate comes with two features:

[features]
formatted = []
one_class_one_file = []

The main crate gdnative exposes a feature formatted, which enables both of the above. This seems to fix the CLion issue, but it also looks like it increases compile time significantly.

In my opinion, we should:

  • find a good balance between compile time and tool-friendlyness
  • make sure the default configuration does not break any tools
  • still allow nicely formatted output (for humans), but not by default
@Bromeon Bromeon added bug c: bindings Component: GDNative bindings (mod api) c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem labels Sep 30, 2021
@Bromeon Bromeon modified the milestones: v0.11, v0.10.1 Nov 1, 2021
@Bromeon Bromeon modified the milestones: v0.10.1, v0.11 Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: bindings Component: GDNative bindings (mod api) c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem
Projects
None yet
Development

No branches or pull requests

1 participant