-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl PartialEq
for Dictionary
and VariantArray
#990
Comments
One interesting decision here -- do we use Rust equality or Godot equality? In most cases it should amount to the same, but I could imagine some subleties, especially with types that involve |
That's good point you bring up. I'd lean toward using Godot's equality operator here to be in line with This could be a good argument for an explicit wrapper as suggested here: #712 (comment). The original suggestion is about a separate type from |
Noteworthy:
I'm not sure if an explicit wrapper type is truly needed, or if a
I'm not sure if the equivalence It eventually amounts to a choice between:
I don't think godot-rust has very clearly favored one way over the other. |
Created during survey of commented code (#377).
Dictionary
andVariantArray
are missingPartialEq
implementations. This is immediately required by the serde serialization test, but should be generally useful to end users as well.The text was updated successfully, but these errors were encountered: