Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid partial repeats of the generated enum names #991

Closed
chitoyuu opened this issue Dec 7, 2022 · 1 comment
Closed

Avoid partial repeats of the generated enum names #991

chitoyuu opened this issue Dec 7, 2022 · 1 comment
Labels
breaking-change Issues and PRs that are breaking to fix/merge. c: bindings Component: GDNative bindings (mod api) quality-of-life No new functionality, but improves ergonomics/internals status: duplicate

Comments

@chitoyuu
Copy link
Contributor

chitoyuu commented Dec 7, 2022

Check whether the start of the variant name is equal to the end of the enum name and if so, don't repeat it. For example, ImageFormat::Rgb8 instead of ImageFormat::FormatRgb8.
@chitoyuu chitoyuu added c: bindings Component: GDNative bindings (mod api) breaking-change Issues and PRs that are breaking to fix/merge. quality-of-life No new functionality, but improves ergonomics/internals labels Dec 7, 2022
@chitoyuu
Copy link
Contributor Author

chitoyuu commented Dec 7, 2022

Originally created during survey of commented code (#377). Actually it appears that this has already been fixed: Format::RGB8

Closing as already solved.

@chitoyuu chitoyuu closed this as completed Dec 7, 2022
@chitoyuu chitoyuu closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Issues and PRs that are breaking to fix/merge. c: bindings Component: GDNative bindings (mod api) quality-of-life No new functionality, but improves ergonomics/internals status: duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chitoyuu