Refactor integration tests by reusing godot_test macro #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces boilerplate of the form
to
which reduces repetition and focuses on important things. This is done by slightly adjusting the existing
godot_test
macro togodot_itest
, which is needed so it can also be used in thetests
crate.This change leads to a net removal of 300 lines of code.
I was also considering a proc-macro attribute
which might be a tiny bit nicer syntax-wise, and even started implementing it. But I think the declarative macro does the job, is simpler and likely faster to compile (as we don't need
syn
to tokenize the entire code).Tests of this form now all have the
#[must_use]
attribute, yielding a warning if a boolean test result is ignored.