Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name=GPUParticles2D type=CPUParticles2D #785

Closed
stevecotton opened this issue Oct 25, 2022 · 1 comment · Fixed by #922
Closed

name=GPUParticles2D type=CPUParticles2D #785

stevecotton opened this issue Oct 25, 2022 · 1 comment · Fixed by #922
Labels

Comments

@stevecotton
Copy link

Which demo project is affected:

  • 2d/physics_platformer
  • 2d/platformer
  • 3d/platformer

Issue description:
Some of the demos in the 4.0-dev branch have instances of CPUParticles2D that are named GPUParticles2D. The discrepancy is already present in the master branch, although it's less obvious without the rename of Particles2D to GPUParticles2D.

Similar applies for 3D, and the first one on this list mixes both "3D" and "2D":

2d/physics_platformer/coin/Coin.tscn:[node name="GPUParticles3D" type="CPUParticles2D" parent="."]
2d/physics_platformer/player/Bullet.tscn:[node name="GPUParticles2D" type="CPUParticles2D" parent="."]
2d/platformer/src/Objects/Bullet.tscn:[node name="GPUParticles2D" type="CPUParticles2D" parent="."]
3d/platformer/coin/coin.tscn:[node name="GPUParticles3D" type="CPUParticles3D" parent="."]
3d/platformer/player/bullet/bullet.tscn:[node name="GPUParticles3D" type="CPUParticles3D" parent="."]
@aaronfranke
Copy link
Member

We could likely change all of the node names to just "Particles" with no prefix or suffix. The type is more of an implementation detail, while the name can be more general purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants