Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Lines in the TextureRegion Dock contrast the Texture's Color #2113

Closed
Arecher opened this issue Jan 13, 2021 · 1 comment · Fixed by godotengine/godot#45164
Closed
Milestone

Comments

@Arecher
Copy link

Arecher commented Jan 13, 2021

Describe the project you are working on

Game Project

Describe the problem or limitation you are having in your project

Ran into a minor inconvenience while working on a white (#ffffff) sprite that I was using in a NinePatchRect. While adjusting the Region Rect through the TextureRegion Dock, the lines that indicate the cut-off point for the NinePatch completely blend with the sprite itself, making it hard to read and work with. The same goes for the outline.

image

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Perhaps it would be better to contrast the lines against the Texture instead. I'm not sure this would look better (especially on textures with a large amount of different colours), but at least it would be clear. Although seeing as this only really happens with extremely white colours, perhaps inverting the colour of the line (or replacing the colour) on those sprites with that colour might be enough.

I'm not really sure how to deal with the outline. It suffers from the same issues, but it needs to be both readable against the background, and against the sprite itself.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

image

contrasting lines of a different colour on the sprite itself

If this enhancement will not be used often, can it be worked around with a few lines of script?

Cannot be worked around, and I'd argue this happens fairly frequently, as little UI pieces are often implemented in #ffffff , so they can easily be modulated through Godot itself.

I do get that adding this feature might be harder than it seems, and that the issue can still be worked with by looking at the variables or the lines on the background. However, I saw it fit to open a proposal for it either way. I am also sure this issue is also present in other (Texture editing) parts of the engine. If I find any, I'll post them in the comments below.

Is there a reason why this should be core and not an add-on in the asset library?

Core: UX issue of a core feature.

@Calinou
Copy link
Member

Calinou commented Jan 13, 2021

Making the dotted line have a translucent black background (Color(0, 0, 0, 0.5)) should solve this elegantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants