Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Filmic tonemapper desaturate bright colors (like ACES) #6096

Open
atirut-w opened this issue Jan 14, 2023 · 2 comments
Open

Make Filmic tonemapper desaturate bright colors (like ACES) #6096

atirut-w opened this issue Jan 14, 2023 · 2 comments

Comments

@atirut-w
Copy link

Describe the project you are working on

N/A. Applies to projects with realistic graphics

Describe the problem or limitation you are having in your project

Currently in both the master branch and 3.x, only the ACES tonemapper has gotten the "fitted" treatment while Filmic stays the same. I can see some people prefering Filmic over ACES since both can be used for more realistic colors with Filmic being on the brighter side.

For details about Filmic, see Color Grading and Filmic Tonemapper(Unreal Doc)

Blender reference:
Screenshot_20220929_172545

Comparison of ACES and Filmic in 4.0
ACES:
Screenshot_20220929_172244
Filmic:
Screenshot_20220929_172340

Same comparison in 3.x
ACES Fitted:
Screenshot_20220929_171928
Filmic:
Screenshot_20220929_172002

Describe the feature / enhancement and how it helps to overcome the problem or limitation

The Filmic tonemapper should desaturate very bright colors, which help projects that have realistic graphics where ACES may not be a good option since it is significantly darker than Filmic.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

N/A. No idea how tonemapping math works.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Rendering is core.

Is there a reason why this should be core and not an add-on in the asset library?

See above.

@Calinou Calinou changed the title Filmic tonemapper should desaturate very bright colors Make Filmic tonemapper desaturate bright colors (like ACES) Jan 14, 2023
@Calinou
Copy link
Member

Calinou commented Jan 14, 2023

@ettiSurreal
Copy link

I am pretty sure that is just an issue with Filmic as a whole. Note that the author of Filmic has made a new version of it called AgX (https://github.com/sobotka/AgX), which i hope will soon be implemented into Blender, effectively replacing Filmic (which is planned to be kept for compatibility). We could potentially take a similar route and deprecate Filmic in favor of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants