Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a secondary light in the Advanced Import Settings preview #6707

Closed
jeronimo-schreyer opened this issue Apr 16, 2023 · 1 comment · Fixed by godotengine/godot#76140
Closed

Comments

@jeronimo-schreyer
Copy link

Describe the project you are working on

a 3D Game with small objects and details

Describe the problem or limitation you are having in your project

It's not much, but I want to preview the object with a little more detail

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I added a secondary light to the preview renderer and UI buttons to turn both lights on and off, just how its done in the materials viewer in the inspector

Screenshot from 2023-04-16 13-47-22

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I basically grabbed the code from EditorMaterialPreviewPlugin

If this enhancement will not be used often, can it be worked around with a few lines of script?

I think this should be in core

Is there a reason why this should be core and not an add-on in the asset library?

This improves the 3D importing experience using the editor

@Calinou
Copy link
Member

Calinou commented Apr 16, 2023

@Calinou Calinou changed the title 3D Advanced Import Settings - add a secondary light in the model previewer Add a secondary light in the Advanced Import Settings preview Apr 16, 2023
@akien-mga akien-mga added this to the 4.3 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants