Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot executable is invalid on macOS #598

Closed
sanchan opened this issue Feb 25, 2024 · 13 comments · Fixed by #632
Closed

Godot executable is invalid on macOS #598

sanchan opened this issue Feb 25, 2024 · 13 comments · Fixed by #632
Labels

Comments

@sanchan
Copy link

sanchan commented Feb 25, 2024

Godot version

v4.2.1.stable.official [b09f793f5]

VS Code version

1.86.2 (Universal)

Godot Tools VS Code extension version

2.0.0

System information

macOS 14.3.1

Issue description

I keep getting this error:

image

when my setting for the editor path is:

image

I suspect it could be related to the Filesystem type. I'm using APFS without case-sensitive (default on macOS)

Steps to reproduce

  • Set in your settings:
"godotTools.editorPath.godot4": "/Applications/Godot.app/Contents/MacOS/Godot",
  • Reload VSCode
@sanchan sanchan added the bug label Feb 25, 2024
@stfufane
Copy link

I can confirm I have the same issue on Mac OS Sonoma with the latest VS Code and version of the plugin. Somehow it doesn't prevent it to work, it just shows this error.

@DaelonSuzuka
Copy link
Collaborator

@sanchan

Your screenshot says (Also modified in workspace). Is there a path specified in ./.vscode/settings.json that's conflicting with the one specified in your user settings?

@stfufane

The error message should probably say some extension features will not work correctly. Only things that require launching a godot process, like using the debugger or opening the Editor, will require the editorPath to be set correctly.

@debris
Copy link

debris commented Feb 26, 2024

Your screenshot says (Also modified in workspace). Is there a path specified in ./.vscode/settings.json that's conflicting with the one specified in your user settings?

This solved the issue for me. Better error message would be definitely helpful. Especially when ./.vscode/settings.json is automatically created and user is oblivious to it's existance

@stfufane
Copy link

You're completely right, didn't notice it either 😬 That fixed it for me too, thanks for the tip !

@DaelonSuzuka
Copy link
Collaborator

Especially when ./.vscode/settings.json is automatically created and user is oblivious to it's existance

...What's automatically creating it? This extension shouldn't have done that. Can you share the entire ./.vscode/settings.json? (and maybe check when it was created?)

Better error message would be definitely helpful.

How do you think it could be improved? It's telling you exactly what path it tried. When you looked at your settings, you didn't notice that it was a different path than your user setting, and you didn't notice the (Also modified in workspace).

User settings being overridden by workspace settings is a fundamental feature of VSCode, and I both can't and wouldn't write the extension to do something like check where a particular setting is defined and react differently based on that.

@joelpryde
Copy link

joelpryde commented Feb 26, 2024

I am getting this issue even with the local workspace settings cleared. I am pointing it at Godot_mono.app btw:
CleanShot 2024-02-26 at 11 49 54@2x

CleanShot 2024-02-26 at 11 50 49@2x

@DaelonSuzuka
Copy link
Collaborator

DaelonSuzuka commented Feb 26, 2024

I'm not a Mac guy, but I think /Applications/Godot_mono.app is a folder.

@stfufane
Copy link

I'm not a Mac guy, but I think /Applications/Godot_mono.app is a folder.

You're totally right ! The complete path should be /Applications/Godot_mono.app/Contents/MacOS/Godot

@joelpryde
Copy link

You are completely correct! My bad, I read "Application" instead of "executable" somehow. All working now. :)

@Calinou
Copy link
Member

Calinou commented Feb 26, 2024

The extension could likely automatically attempt Contents/MacOS/Godot within the specified path when on macOS if the path doesn't exist.

@brian-xu
Copy link

brian-xu commented Mar 1, 2024

After moving the application to my $HOME directory as suggested in the above mention, both issues appear to have completely disappeared.

@charafau
Copy link

After moving the application to my $HOME directory as suggested in the above mention, both issues appear to have completely disappeared.

as strange as it seems, it was also solution for me

@christo8989
Copy link

This is what worked for me. /Applications/Godot.app/Contents/MacOS/Godot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants