TinyEXR module cross-build fails on macOS (mingw-w64)

[bruvzg]

Operating system or device, Godot version, GPU Model and driver (if graphics related):

macOS 10.13.1; mingw-w64 5.0.3 (macports); gcc 7.2.0; Godot 3.0 (9a96a2a)

Build command: scons -j8 p=windows tools=yes bits=64 target=debug

Probably macOS specific, I didn't encountered this problem on Linux or MSYS2.

Issue description:
Multiple occurrences of fopen_s was not declared in this scope errors:

In file included from thirdparty/tinyexr/tinyexr.cc:2:0:
thirdparty/tinyexr/tinyexr.h: In function <<int LoadEXRImageFromFile(EXRImage*, const EXRHeader*, const char*, const char**)>>:
thirdparty/tinyexr/tinyexr.h:10838:3: error: <<fopen_s>> was not declared in this scope
   fopen_s(&fp, filename, "rb");
   ^~~~~~~
...

Steps to reproduce:
Compile Godot with mingw-w64 on macOS.

Edit:
Same happens with updated TinyEXR from #14006

[akien-mga]

There was the same issue on Linux with mingw-w64 3.x, but it's been fixed since 4.x. So I wonder why it's triggered for you with mingw-w64 5.0.3.

We can extend the logic of this hack (37f5e1d) so that it builds with macports' mingw-w64, but I'd suggest to also make a bug report upstream about that as it seems to be a bug if it works fine on Windows and Linux but not on macOS.

[bruvzg]

Problem can be fixed by building with CCFLAGS=-DMINGW_HAS_SECURE_API, look like macports mingw-w64 is configured without --enable-secure-api flag.

[akien-mga]

I guess you should open a ticket with macports to see if they'd consider enabling this flag? If not and for a valid reason, tinyexr should be patched to take it into account (ideally upstream).

[bruvzg]

macports accepted change: macports/macports-ports@6196ddb, closing.