Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphic artifact when environment Glow is turned on #17036

Closed
kubecz3k opened this issue Feb 26, 2018 · 4 comments
Closed

Graphic artifact when environment Glow is turned on #17036

kubecz3k opened this issue Feb 26, 2018 · 4 comments

Comments

@kubecz3k
Copy link
Contributor

kubecz3k commented Feb 26, 2018

Godot version:
3.0.1, but the issue is present in 3.0 as well

OS/device including version:
Ubuntu 17.04, gpu: GTX1060

Issue description:
I noticed that rarely in my game some elements are starting to shine for one frame when camera is moving around, after investigation it turns out that it's caused by GLOW in environment node. I was able to record short gif of it with still camera:
shine_artifact
the effect is immediately appearing/disappearing if I move camera in any direction, it's the most noticeable when camera moves (one frame brightness), but it's impossible to capture it in such motion on gif

Steps to reproduce:

  1. For the most visible effect download reproduction project (little modified materials demo). Or alternatively you can open material demo and turn GLOW on in environment node.

Minimal reproduction project:
https://www.dropbox.com/s/ga20u9qq9vpbf84/MaterialTesterGlowArtifacts.7z?dl=0 (file to big to upload on github)

@ghost ghost added this to the 3.1 milestone Feb 26, 2018
@reduz
Copy link
Member

reduz commented Sep 6, 2018

This usually happens due to specular blobs.. maybe I should add something to limit specular strength in some materials.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Jan 19, 2019
@akien-mga akien-mga modified the milestones: 3.2, 4.0 Dec 13, 2019
@clayjohn
Copy link
Member

clayjohn commented Sep 1, 2020

I think this is fixed in 4.0 already. Realistically it is not something that can be "fixed" but the impact is reduced by improvements to specular aliasing (roughness limiter and FXAA) and to the glow effect itself.

@clayjohn
Copy link
Member

Fixed by #54409

@Calinou
Copy link
Member

Calinou commented Apr 26, 2022

For people finding this issue via a web search, note that a variant of this issue still exists in 3.x: #15756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants