Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate particles material from 2D and 3D due to properties bounds inconsistencies #18243

Closed
Ranoller opened this issue Apr 17, 2018 · 1 comment

Comments

@Ranoller
Copy link
Contributor

Godot version:

Godot 3 upt to master

OS/device including version:

All

Issue description:

From godot 3 and the addition of particles material, 2D and 3D share same code. Properties bounds that works well or have a significative impact in 3D doesn´t have much effect in 2D and backwards (bounds seems to be programmed with 3D in mind). I was looking for change this bounds in:

scene\3d\particles.cpp:
void ParticlesMaterial::_bind_methods()

But if i change that for do feasible some effects that with actual bounds you can´t get in 2D... well, parameter-bound for 3D become oversized. This can be accomplished by separating both codes... I do not feel capable to do that, so this is a ... feature request?

But if nobody have problem with upper bounds for 3D (Doesn´t break compatibility, only can make crazy effects in the upper side of the bound....), I can change directly this code.

@Calinou
Copy link
Member

Calinou commented Jun 18, 2020

Closing in favor of godotengine/godot-proposals#815, as feature proposals are now tracked on the Godot proposals repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants