-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPUParticles2D renders wrong with GLES2 on iOS if scene uses NinePatchRect, Panel, Button or ProgressBar #32837
Comments
cc @clayjohn |
Is this a regression from 3.1.1? Or is the issue present there as well? |
@clayjohn 3.1.1-stable (official) has the same problem. |
3.2-alpha 48d3458 also has the same issue. |
@clayjohn would you have a look for this? 😃 |
Im sorry, I don't have an IOS device to test on, so I don't even know where to start... :/ I looked through the code when you first posted this, but nothing jumped out at me. Without being able to reproduce I can't really do anything more. |
thank you for your time anyway. 👍 |
Comment from @klimi15 in #34637:
|
NinePatchRect, Panel, Button and ProgressBar are all GUI elements which can use nine-patch slicing feature for their stylebox textures, so the issue is probably related to that codepath. |
I would like for this to get fixed, but unfortunately we don't have anyone stepping up that can work on iOS, so bumping to 4.0. |
Good news! I am fairly certain this is the same underlying bug as #38318 which seems to be solved by #38318 (comment) If it is, we should have a fix on the way shortly. :) |
Can you confirm if this is now fixed in 3.2.3 / 3.2.4-beta1? |
tested with 3.2.4-beta 150f9ce |
@volzhs did you disable half floats using the added project setting? |
@clayjohn all settings are default. |
@volzhs do you mind trying again with the disable_half_float setting? |
@clayjohn yeah. that made it work. I just read the description of this option. |
Godot version:
Godot 3.1.1-stable official
Godot 3.1.2-alpha 8f3fea2
Godot 3.2-alpha 48d3458
OS/device including version:
iPad 6th gen / 12.3.1
Issue description:
CPUParticles2D renders wrongly when scene has NinePatchRect on GLES2.
Here is a table to show if it renders correctly.
on GLES3
on GLES2
Steps to reproduce:
NinePatchRect
andCPUParticles2D
Minimal reproduction project:
test particle.zip
The text was updated successfully, but these errors were encountered: