Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: LightmapProbes only bake indirect light #40181

Closed
Tracked by #56033
ghost opened this issue Jul 7, 2020 · 3 comments
Closed
Tracked by #56033

Vulkan: LightmapProbes only bake indirect light #40181

ghost opened this issue Jul 7, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 7, 2020

Godot version:
master (d0e0a19)

OS/device including version:
NVIDIA GeForce GTX 1060 6GB
Driver 451.48
Windows 10 Home
Backend: Vulkan

Issue description:
LightmapProbes disregard DirectionalLight3Ds, instead baking only indirect light. The lightmap itself does bake DirectionalLight3Ds, however the LightmapProbes that are generated only bake indirect light.

Steps to reproduce:
Create a test scene which contains a BakedLightmap node and meshes with a UV2 channel for lightmap baking. Create a DirectionalLight3D and set its bake mode to Static. View the lightmap probes and see how they only have indirect lighting data and not direct lighting data.

Bugsquad edit (keywords for easier searching): LightmapGI

@Chaosus Chaosus added this to the 4.0 milestone Jul 7, 2020
@Calinou Calinou changed the title 4.0 LightmapProbes only bake indirect light Vulkan: LightmapProbes only bake indirect light Jul 4, 2021
@Darkinggq
Copy link

Godot version: 5c3055e
Linux , RX5500XT (Mesa 21.1.3)

LightmapProbe does not work on the cube ignore in indirect light apparently does not work

image

TestLightmapProbe.tar.gz

@Calinou
Copy link
Member

Calinou commented Jul 4, 2021

Note that this behavior may also be pressent in 3.x. However, in 3.x, lights with the bake mode set to All will light up dynamic objects so that these objects can receive direct light (and receive shadows from other objects, including baked ones).

Edit (January 2022): An equivalent of #41629 was added to master, bringing behavior similar to the paragraph I wrote above. However, dynamic object lighting isn't rendered correctly.

@Calinou
Copy link
Member

Calinou commented Mar 15, 2023

As for baking direct light into lightmap probes, see #73289.

@Calinou Calinou closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2023
@Calinou Calinou removed this from the 4.x milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants