Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLB fails to import textures #44027

Closed
Wavesonics opened this issue Dec 2, 2020 · 5 comments
Closed

GLB fails to import textures #44027

Wavesonics opened this issue Dec 2, 2020 · 5 comments

Comments

@Wavesonics
Copy link
Contributor

Wavesonics commented Dec 2, 2020

Godot version:
4.0

OS/device including version:
Win64

Issue description:
This GLB imports it's geometry correctly once #44023 is merged.

However it's textures fail to load:

It is all black: (4.0)
Screenshot 2020-12-01 154828

It should look like this: (3.2)
Screenshot 2020-12-01 155127

These errors show up in the terminal: (4.0)

ERROR: 1 shaders of type CanvasSdfShaderRD were never freed
   at: ShaderRD::~ShaderRD (servers\rendering\rasterizer_rd\shader_rd.cpp:470)
ERROR: Invalid Object id '25367151136', can't call method.
   at: (D:\Code\External\godot\core/object/callable_method_pointer.h:95)

ERROR: Condition "p_size < 0" is true. Returning: ERR_INVALID_PARAMETER
   at: CowData<struct Vector2>::resize (D:\Code\External\godot\core/templates/cowdata.h:252)
ERROR: Cannot open file 'res://.import/cop_car.glb-d1da082c95816014f295a29160723f8f.scn'.
   at: (core\io\resource_format_binary.cpp:1030)
Adding mesh..
Generate..
Final texture size: 134.000000,134.000000 - max 133.500000,133.500000
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Another resource is loaded from path 'res://cop_car/police_car.mesh' (possible cyclic resource inclusion).
   at: (core\io\resource.cpp:79)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)
ERROR: Texture (binding: 0, index 0) is not a valid texture.
   at: (drivers\vulkan\rendering_device_vulkan.cpp:4680)
ERROR: Condition "!uniform_set" is true.
   at: RenderingDeviceVulkan::draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6143)
ERROR: Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
   at: (drivers\vulkan\rendering_device_vulkan.cpp:6285)

Steps to reproduce:
Load the sample project in master, it will import the cop_car.glb file. Then in Godot, open the model to view it.

Minimal reproduction project:
ImportCrash.zip

@Calinou Calinou added this to the 4.0 milestone Dec 2, 2020
@fire
Copy link
Member

fire commented Dec 2, 2020

Is this fixed?

@Wavesonics
Copy link
Contributor Author

Wavesonics commented Dec 2, 2020

No, this appears to be an unrelated issue to the crash with the same model. This texture issue only exists in 4.0. (where as the crash existed in both branches)

@fire
Copy link
Member

fire commented Dec 11, 2020

A entirely black scene should give a black shading. Are you sure you have lighting?

@Blackiris
Copy link
Contributor

Just tried again to open the reproduction project, with one of the latest master build (14cc1df) and I don't encounter the issue.
image

Could you confirm if it works now for you?

@fire
Copy link
Member

fire commented Jul 10, 2021

As this is confirmed fixed, we close this issue.

If it is still relevant in the way it was described and discussed above, please comment to ask for it to be reevaluated. If it is only partly relevant, or if the original issue has changed, it would be better to open a new issue (potentially referring to this one) focused on the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants